Skip to content

Add image request priority debug overlay (#56970)#56970

Closed
sammy-SC wants to merge 2 commits into
facebook:mainfrom
sammy-SC:export-D106363533
Closed

Add image request priority debug overlay (#56970)#56970
sammy-SC wants to merge 2 commits into
facebook:mainfrom
sammy-SC:export-D106363533

Conversation

@sammy-SC
Copy link
Copy Markdown
Contributor

@sammy-SC sammy-SC commented May 26, 2026

Summary:

changelog: [internal]

Add an opt-in RCT_IMAGE_REQUEST_PRIORITY_DEBUG_OVERLAY label for Fabric image component views so local debugging can show whether an image request is using immediate priority or the offscreen prefetch path.

Reviewed By: christophpurrer

Differential Revision: D106363533

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 26, 2026

@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106363533.

@meta-codesync meta-codesync Bot changed the title Add image request priority debug overlay Add image request priority debug overlay (#56970) May 26, 2026
@sammy-SC sammy-SC force-pushed the export-D106363533 branch from d16cd09 to 52decda Compare May 26, 2026 20:53
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request May 26, 2026
Summary:
Pull Request resolved: facebook#56970

Add an opt-in `RCT_IMAGE_REQUEST_PRIORITY_DEBUG_OVERLAY` label for Fabric image component views so local debugging can show whether an image request is using immediate priority or the offscreen prefetch path.

Reviewed By: christophpurrer

Differential Revision: D106363533
@sammy-SC sammy-SC force-pushed the export-D106363533 branch from 52decda to 1a1b8af Compare May 27, 2026 09:25
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request May 27, 2026
Summary:
Pull Request resolved: facebook#56970

Add an opt-in `RCT_IMAGE_REQUEST_PRIORITY_DEBUG_OVERLAY` label for Fabric image component views so local debugging can show whether an image request is using immediate priority or the offscreen prefetch path.

Reviewed By: christophpurrer

Differential Revision: D106363533
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request May 27, 2026
Summary:
Pull Request resolved: facebook#56970

changelog: [internal]

Add an opt-in `RCT_IMAGE_REQUEST_PRIORITY_DEBUG_OVERLAY` label for Fabric image component views so local debugging can show whether an image request is using immediate priority or the offscreen prefetch path.

Reviewed By: christophpurrer

Differential Revision: D106363533
@sammy-SC sammy-SC force-pushed the export-D106363533 branch 2 times, most recently from c45a588 to aa1d4a2 Compare May 27, 2026 09:44
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request May 27, 2026
Summary:
Pull Request resolved: facebook#56970

changelog: [internal]

Add an opt-in `RCT_IMAGE_REQUEST_PRIORITY_DEBUG_OVERLAY` label for Fabric image component views so local debugging can show whether an image request is using immediate priority or the offscreen prefetch path.

Reviewed By: christophpurrer

Differential Revision: D106363533
sammy-SC added 2 commits May 27, 2026 03:21
Summary: Use Fabric layout data to classify image shadow nodes as visible or offscreen on Apple platforms. Offscreen image requests now use `ImageRequestPriority::Prefetch`, which is bridged to the existing `RCTImageLoaderPriorityPrefetch` API, while visible images stay at `Immediate`; the new React Native feature flag defaults to `false` until app-specific gating wires it up.

Differential Revision: D106074485
Summary:
Pull Request resolved: facebook#56970

changelog: [internal]

Add an opt-in `RCT_IMAGE_REQUEST_PRIORITY_DEBUG_OVERLAY` label for Fabric image component views so local debugging can show whether an image request is using immediate priority or the offscreen prefetch path.

Reviewed By: christophpurrer

Differential Revision: D106363533
@sammy-SC sammy-SC force-pushed the export-D106363533 branch from aa1d4a2 to 4882a4a Compare May 27, 2026 10:27
@meta-codesync meta-codesync Bot closed this in d4ae881 May 27, 2026
@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label May 27, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 27, 2026

This pull request has been merged in d4ae881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant